8303472: Display name for region TR #12816

justin-curtis-lu · 2023-03-01T21:58:00Z

This PR changes the English name for the region TR, from Turkey to Türkiye. Although this change is included in the upcoming CLDR v43, it should be applied as a spot change so that it can be back-ported properly (As it is a common English region name).

This change targets both the CLDR and COMPAT data.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8303472: Display name for region TR

Reviewers

Naoto Sato (@naotoj - Reviewer)
@srl295 (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12816/head:pull/12816
$ git checkout pull/12816

Update a local copy of the PR:
$ git checkout pull/12816
$ git pull https://git.openjdk.org/jdk pull/12816/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12816

View PR using the GUI difftool:
$ git pr show -t 12816

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12816.diff

bridgekeeper · 2023-03-01T21:59:14Z

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2023-03-01T22:02:35Z

@justin-curtis-lu The following labels will be automatically applied to this pull request:

build
core-libs
i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2023-03-01T22:06:13Z

Webrevs

01: Full - Incremental (5bedc6a0)
00: Full (c996ca27)

naotoj

Please supply test cases with these changes (sun/text/resources/LocaleDataTest.java), also copyright year changes for COMPAT properties.
Otherwise LGTM

naotoj · 2023-03-01T22:52:09Z

src/java.base/share/classes/sun/util/resources/LocaleNames.properties

@@ -1094,7 +1094,7 @@ TL=Timor-Leste
 TM=Turkmenistan
 TN=Tunisia
 TO=Tonga
-TR=Turkey
+TR=T�rkiye


I believe this is fine, but please confirm that this ends up correct u-umlaut when you get the text. It is somewhat a rare case where ISO-8859-1 has the character and the byte sequence differs between ISO-8859-1 and UTF-8.

Thanks for pointing that out, I switched it to just be a unicode escaped ü, as that would be more consistent with the rest of the file. I also added the changes to the test files like you suggested.

naotoj · 2023-03-01T23:05:33Z

/label remove build

openjdk · 2023-03-01T23:07:14Z

@naotoj
The build label was successfully removed.

openjdk · 2023-03-02T16:16:48Z

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303472: Display name for region TR

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

ae797c6: 8301117: Remove old_size param from ResizeableResourceHashtable::resize()
5085bd5: 8297936: Use reachabilityFence to manage liveness in ClassUnload tests
379f206: 8303198: System and Runtime.exit() resilience to logging errors
80739e1: 8279619: [JVMCI] improve EncodedSpeculationReason
7449e1c: 8299807: newStringNoRepl should avoid copying arrays for ASCII compatible charsets
c6de66c: 8303516: HFAs with nested structs/unions/arrays not handled correctly on AArch64
cbdc7a6: 8303481: CancelRequestTest assertTrue failing with AssertionError due to java.util.concurrent.CompletionException: java.io.EOFException: EOF reached while reading
8bf084c: 8303499: [s390x] ProblemList StressStackOverflow
ff364c1: 8301622: ProcessTools.java compilation gets ThreadDeath deprecation warning
df9aad0: 8297955: LDAP CertStore should use LdapName and not String for DNs
... and 28 more: https://git.openjdk.org/jdk/compare/4c985e527a4a03d5a78d85a145aa41c1843a3e22...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

justin-curtis-lu · 2023-03-03T17:04:03Z

/integrate

openjdk · 2023-03-03T17:05:39Z

@justin-curtis-lu
Your change (at version 5bedc6a) is now ready to be sponsored by a Committer.

naotoj · 2023-03-03T17:16:52Z

/sponsor

openjdk · 2023-03-03T17:18:52Z

Going to push as commit e3016c1.
Since your change was applied there have been 38 commits pushed to the master branch:

ae797c6: 8301117: Remove old_size param from ResizeableResourceHashtable::resize()
5085bd5: 8297936: Use reachabilityFence to manage liveness in ClassUnload tests
379f206: 8303198: System and Runtime.exit() resilience to logging errors
80739e1: 8279619: [JVMCI] improve EncodedSpeculationReason
7449e1c: 8299807: newStringNoRepl should avoid copying arrays for ASCII compatible charsets
c6de66c: 8303516: HFAs with nested structs/unions/arrays not handled correctly on AArch64
cbdc7a6: 8303481: CancelRequestTest assertTrue failing with AssertionError due to java.util.concurrent.CompletionException: java.io.EOFException: EOF reached while reading
8bf084c: 8303499: [s390x] ProblemList StressStackOverflow
ff364c1: 8301622: ProcessTools.java compilation gets ThreadDeath deprecation warning
df9aad0: 8297955: LDAP CertStore should use LdapName and not String for DNs
... and 28 more: https://git.openjdk.org/jdk/compare/4c985e527a4a03d5a78d85a145aa41c1843a3e22...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-03-03T17:19:07Z

@naotoj @justin-curtis-lu Pushed as commit e3016c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

justin-curtis-lu added 2 commits March 1, 2023 11:32

Spot change TR region name

2897613

Spot change TR for COMPAT

c996ca2

openjdk bot added the rfr Pull request is ready for review label Mar 1, 2023

openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Mar 1, 2023

naotoj reviewed Mar 1, 2023

View reviewed changes

openjdk bot removed the build build-dev@openjdk.org label Mar 1, 2023

justin-curtis-lu added 2 commits March 1, 2023 15:27

copyright year

803e9ec

Supply test with changes, use unicode escapes to be consistent

5bedc6a

naotoj approved these changes Mar 2, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 2, 2023

srl295 approved these changes Mar 2, 2023

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 3, 2023

openjdk bot added the integrated Pull request has been integrated label Mar 3, 2023

openjdk bot closed this Mar 3, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8303472: Display name for region TR #12816

8303472: Display name for region TR #12816

justin-curtis-lu commented Mar 1, 2023 •

edited by openjdk bot

bridgekeeper bot commented Mar 1, 2023

openjdk bot commented Mar 1, 2023

mlbridge bot commented Mar 1, 2023 •

edited

naotoj left a comment

naotoj Mar 1, 2023 •

edited

justin-curtis-lu Mar 1, 2023

naotoj commented Mar 1, 2023

openjdk bot commented Mar 1, 2023

openjdk bot commented Mar 2, 2023 •

edited

justin-curtis-lu commented Mar 3, 2023

openjdk bot commented Mar 3, 2023

naotoj commented Mar 3, 2023

openjdk bot commented Mar 3, 2023

openjdk bot commented Mar 3, 2023

8303472: Display name for region TR #12816

8303472: Display name for region TR #12816

Conversation

justin-curtis-lu commented Mar 1, 2023 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Mar 1, 2023

openjdk bot commented Mar 1, 2023

mlbridge bot commented Mar 1, 2023 • edited

Webrevs

naotoj left a comment

Choose a reason for hiding this comment

naotoj Mar 1, 2023 • edited

Choose a reason for hiding this comment

justin-curtis-lu Mar 1, 2023

Choose a reason for hiding this comment

naotoj commented Mar 1, 2023

openjdk bot commented Mar 1, 2023

openjdk bot commented Mar 2, 2023 • edited

justin-curtis-lu commented Mar 3, 2023

openjdk bot commented Mar 3, 2023

naotoj commented Mar 3, 2023

openjdk bot commented Mar 3, 2023

openjdk bot commented Mar 3, 2023

justin-curtis-lu commented Mar 1, 2023 •

edited by openjdk bot

mlbridge bot commented Mar 1, 2023 •

edited

naotoj Mar 1, 2023 •

edited

openjdk bot commented Mar 2, 2023 •

edited